Melanoma task #310
Open
Melanoma task #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. also delete the tarball after done using
Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.8 to 4.6.9. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.8...v4.6.9) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
sebffischer
requested changes
Nov 29, 2024
| old = c("image", "patient", "anatom_site_general"), | ||
| new = c("image_name", "patient_id", "anatom_site_general_challenge") | ||
| )[, split := "test"] | ||
| metadata = rbind(training_metadata, test_metadata, fill = TRUE) |
sebffischer
reviewed
Nov 29, 2024
cxzhang4
commented
Nov 29, 2024
|
And yes, I would delete the individual files on huggingface |
…y_imagenet. Probably need to construct full file paths first
sebffischer
reviewed
Nov 29, 2024
R/TaskClassif_melanoma.R
Outdated
| @@ -83,7 +83,7 @@ load_task_melanoma = function(id = "melanoma") { | |||
| cached_constructor = function(backend) { | |||
| data = cached(constructor_melanoma, "datasets", "melanoma")$data | |||
|
|
|||
| data[, benign_malignant := factor(benign_malignant, levels = c("benign", "malignant"))] | |||
| data[, outcome := factor(outcome, levels = c("benign", "malignant"))] | |||
There was a problem hiding this comment.
the static analyzer will not know that outcome is a valid variable here (this is generally an issue with NSE)
you can use outcome := factor(get("outcome"), ...) as a workaround
There was a problem hiding this comment.
With this change, the linter gives the following warning: no visible binding for global variable 'outcome'. Using set() does also. Is this an issue? If I understand correctly, that means the problem is still there
There was a problem hiding this comment.
this is also not what I wrote. I said get("outcome")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://huggingface.co/datasets/carsonzhang/ISIC_2020_small
Should we delete the individual files on Hugging Face?
Edit: deleted